fix 32-bit overflow in ICC CICP tag-count bounds check#234
Open
rootvector2 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
12 * tag_countin FindCICPTag is computed in 32-bit, so a crafted ICC profile with tag_count=0x40000000 wraps132 + 12 * tag_countback to 132 and slips past the length guard. The loop then readsicc_data[132 + 12*i]past the end of the profile. tag_count comes from offset 128 of the embedded profile, which is attacker-controlled when transcoding an image. Widen the multiply to 64-bit.