fix jdimension overflow in jpegli_crop_scanline bounds check#242
Open
rootvector2 wants to merge 1 commit into
Open
fix jdimension overflow in jpegli_crop_scanline bounds check#242rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
*xoffset + *widthinjpegli_crop_scanlineis computed in 32-bitJDIMENSION, so a large*xoffsetwraps the sum belowoutput_widthand the bounds check accepts an out-of-range crop window;master->xoffset_is then left out of range andWriteToOutputreads the decoded component rows past their end, with the bytes landing in the caller's scanline buffer. found auditing the crop api. the check is rewritten to compare without the addition, which also covers thejpeg_crop_scanlinewrapper, and a regression test is added.Pull Request Checklist
./ci.sh lintfor automatic code formatting.