perf(adapter/megatron): do sync save in main thread, not separate process#107
Draft
perf(adapter/megatron): do sync save in main thread, not separate process#107
Conversation
Python Code Coverage Summary
Minimum allowed line rate is |
C++ Code Coverage Summary
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default sync save impl in Megatron's
AsyncSaveShardedStrategy, which is thesave()method, simply callsasync_save(...), schedules it (which kicks off a worker process to do the work), then blocks and waits for that process to finish, and cleans it up if it is not a persistent process.This adds unnecessary overhead when doing synchronous saving, as all that work can just be done in the main thread, which is simpler. This change does just that.