fix: gitter falls back to reclone too often - #5890
Open
Ly-Joey wants to merge 7 commits into
Open
Conversation
Ly-Joey
force-pushed
the
fix-gitter-reclone-too-much
branch
2 times, most recently
from
August 24, 2026 03:52
ceb5156 to
79cc3de
Compare
another-rex
reviewed
Aug 24, 2026
another-rex
reviewed
Aug 24, 2026
another-rex
left a comment
another-rex
left a comment
Contributor
There was a problem hiding this comment.
Nice, some small notes
Co-authored-by: Rex P <106129829+another-rex@users.noreply.github.com>
Ly-Joey
force-pushed
the
fix-gitter-reclone-too-much
branch
from
August 24, 2026 06:34
b7f1ad4 to
b789eb0
Compare
another-rex
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when a fetch fails for any reason, gitter basically immediately falls back to doing a full reclone of the repository as recovery.
But this is problematic when the failure is due to upstream issues, such as getting rate-limited or when the remote server has an intermittent failure (we've seen some upstream OOM in our logs).
This PR:
refreshRepofunction to skip reclone fallback when it's a rate-limit or upstream error.Fixes: #5807
Stack created with GitHub Stacks CLI • Give Feedback 💬