Skip to content

prepacked_cache: fix byte-accounting for evicted float matrices #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EylonKrause wants to merge 1 commit into
base: master
Choose a base branch
from
Open

prepacked_cache: fix byte-accounting for evicted float matrices #374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ruy/prepacked_cache.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,16 @@ void PrepackedCache::EjectOne() {
}
}
const PEMat& packed_matrix = oldest->second.packed_matrix;
buffers_bytes_ -= DataBytes(packed_matrix) + SumsBytes(packed_matrix);
// Mirror the accounting done in AllocateBuffers: floating-point matrices do
// not allocate a `sums` buffer, so only their `data` bytes were ever added
// to buffers_bytes_. Unconditionally subtracting SumsBytes here would
// over-subtract for float matrices (whose sums_type still has nonzero size),
// letting buffers_bytes_ drift below the true usage and the cache overshoot
// its cap.
buffers_bytes_ -= DataBytes(packed_matrix);
if (!packed_matrix.sums_type.is_floating_point) {
buffers_bytes_ -= SumsBytes(packed_matrix);
}
FreeBuffers(packed_matrix);
cache_.erase(oldest);
}
Expand Down