feat: replace pylint with Pyrefly - #177
Conversation
Replace pylint with Pyrefly type checker to align with Google's internal tooling. This change: - Adds pyrefly.toml with the blessed Google OSS configuration - Replaces pylint with pyrefly in pre-commit hooks - Replaces pylint with pyrefly in Makefile targets - Updates dev dependencies in pyproject.toml - Removes .pylintrc (no longer needed) Fixes google#174 Signed-off-by: mercael <mercael91@gmail.com>
|
Pushed an update: feat: replace pylint with Pyrefly. Ready for re-review when you have a moment. |
1 similar comment
|
Pushed an update: feat: replace pylint with Pyrefly. Ready for re-review when you have a moment. |
|
Closing this PR — it has been open for over a week without a response. Thank you for the project; happy to reopen or continue if there is interest. |
There was a problem hiding this comment.
Hi @mercael91 thanks for this PR.
Sorry if you felt we moved a little slow in reviewing this PR.
Perhaps we should update the documentation to give guidance about slower expected review pace.
As a side note, we had an existing Pyrefly effort going in #175.
We definitely welcome your contributions moving forward!
| #entry: pylint --rcfile=.pylintrc --ignore=proto smart_control | ||
| #entry: pylint --rcfile=.pylintrc --ignore=proto $(git diff --name-only --staged | grep -E '\.py$') | ||
| entry: pylint --rcfile=.pylintrc --ignore=proto | ||
| - id: pyrefly |
There was a problem hiding this comment.
Just to clarify, pyrefly is replacing pytype, not pylint. Sorry for any confusion. I have updated the issue description.
2 participants
Summary
Replace pylint with Pyrefly type checker to align with Google's internal tooling, as described in #174.
Changes
pyrefly.tomlwith the blessed Google OSS configuration from the issue.pre-commit-config.yaml— replaced pylint hook withpyrefly checkMakefile— replacedpylinttarget withpyreflytargetpyproject.toml— replacedpylintandpylint-per-file-ignoresdev dependencies withpyrefly>=0.20.0.pylintrc— no longer neededFixes #174