Move seconds_to_rads to a standalone function - #182
Open
Mustaphayinka wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #117
Moves secondstorads out of WeatherController and into a standalone, module-level function, following your follow-up advice to use a standalone function instead of a static method.
Changes: The function now sits above BaseWeatherController, and the nonexistent self parameter has been removed. WeatherController.getcurrenttemp is called directly at its call site rather than through self. In weathercontrollertest.py, testsecondstorad now calls weathercontroller.secondstorads(...) directly, so it tests a pure function.
Verified that the function’s output exactly matches all three existing test cases (minrad, maxrad, mid_rad).