Interpolate by column name instead of a values property - #183
Open
Mustaphayinka wants to merge 1 commit into
Open
Interpolate by column name instead of a values property#183Mustaphayinka wants to merge 1 commit into
Mustaphayinka wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #149
Reworks getinterpolatedvalue so it accepts a column name (str) instead of a pre-fetched pd.Series, then looks up that column internally from weatherdf. This eliminates the need for a separate property for each column, such as temps_f and humidities, which #149 identified as inflexible.
Changes: getinterpolatedvalue now accepts columnname: str rather than values: pd.Series. The unnecessary tempsf and humidities properties have been removed. getcurrenttemp passes 'TempF' directly, matching the column name documented in readweathercsv's docstring, while getcurrenthumidity passes self.humiditycolumn so the existing configurable column-name behavior remains intact.
getcurrenttemp and getcurrenthumidity retain their exact public signatures, so callers elsewhere in the simulator—airhandler.py, simulator.py, solarradiation.py, and others remain unaffected. A search confirmed that none of them access the removed properties or call the private helper directly.
A manual check against the existing test fixture, localweathertestdata.csv, also passed: at 2023-07-01 03:00:01+00:00, getcurrenttemp returns 298.15, matching the value expected by the existing test. For that same timestamp, getcurrent_humidity returns 50.0.