Skip to content

fix(bigtable): use google-c2p:// as the Bigtable DirectPath endpoint #16092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elinorli wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −5
Open

fix(bigtable): use google-c2p:// as the Bigtable DirectPath endpoint #16092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google/cloud/bigtable/internal/defaults.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ Options DefaultOptions(Options opts) {
// Set the specific data endpoints if Direct Path is enabled.
if (IsDirectPath()) {
opts.set<::google::cloud::bigtable_internal::DataEndpointOption>(
"c2p:///bigtable.googleapis.com")
"google-c2p:///bigtable.googleapis.com")
.set<AuthorityOption>("bigtable.googleapis.com");
}

Expand Down
10 changes: 6 additions & 4 deletions google/cloud/bigtable/internal/defaults_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ TEST(EndpointEnvTest, CloudDirectPathEnabled) {
ScopedEnvironment cbt_direct_path("CBT_ENABLE_DIRECTPATH", absl::nullopt);

auto opts = DefaultOptions();
EXPECT_EQ("c2p:///bigtable.googleapis.com",
EXPECT_EQ("google-c2p:///bigtable.googleapis.com",
opts.get<::google::cloud::bigtable_internal::DataEndpointOption>());
EXPECT_EQ("bigtable.googleapis.com", opts.get<AuthorityOption>());
// Admin endpoints are not affected.
Expand All @@ -525,7 +525,7 @@ TEST(EndpointEnvTest, BigtableDirectPathEnabled) {
ScopedEnvironment cbt_direct_path("CBT_ENABLE_DIRECTPATH", "true");

auto opts = DefaultOptions();
EXPECT_EQ("c2p:///bigtable.googleapis.com",
EXPECT_EQ("google-c2p:///bigtable.googleapis.com",
opts.get<::google::cloud::bigtable_internal::DataEndpointOption>());
EXPECT_EQ("bigtable.googleapis.com", opts.get<AuthorityOption>());
// Admin endpoints are not affected.
Expand Down Expand Up @@ -564,7 +564,8 @@ TEST(EndpointEnvTest, CloudDirectPathOverridesUserEndpoints) {

auto opts = DefaultDataOptions(
Options{}.set<EndpointOption>("ignored").set<AuthorityOption>("ignored"));
EXPECT_EQ("c2p:///bigtable.googleapis.com", opts.get<EndpointOption>());
EXPECT_EQ("google-c2p:///bigtable.googleapis.com",
opts.get<EndpointOption>());
EXPECT_EQ("bigtable.googleapis.com", opts.get<AuthorityOption>());
}

Expand All @@ -574,7 +575,8 @@ TEST(EndpointEnvTest, BigtableDirectPathOverridesUserEndpoints) {

auto opts = DefaultDataOptions(
Options{}.set<EndpointOption>("ignored").set<AuthorityOption>("ignored"));
EXPECT_EQ("c2p:///bigtable.googleapis.com", opts.get<EndpointOption>());
EXPECT_EQ("google-c2p:///bigtable.googleapis.com",
opts.get<EndpointOption>());
EXPECT_EQ("bigtable.googleapis.com", opts.get<AuthorityOption>());
}

Expand Down
Loading