Conversation
Pin gapic-showcase installation in showcase_server.dart to v0.40.0 instead of @latest. - Upstream gapic-showcase v0.41.1/v0.42.0 fails to compile due to an undefined tls.SecP256r1MLKEM768 identifier in Go TLS adapters. - Pinned version resolves all showcase conformance test failures in CI. - Ran dart format across modified test files.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request formats a test case in echo_test.dart and pins the gapic-showcase installation version to v0.40.0 instead of latest in showcase_server.dart to ensure reproducible builds. There are no review comments, and I have no feedback to provide.
|
/gcbrun |
Fix the log query in the structured logging integration test and add diagnostic logging to waitForLogs. - Update the 'structured logging' test in pkgs/google_cloud_shelf/test/logging_test.dart to query 'jsonPayload.message' instead of 'textPayload' (Cloud Run ingests structured JSON logs into jsonPayload). - Add a 2-minute timeout to the 'logging server' test group so waitForLogs has sufficient time to complete. - Add polling progress logs in test_utils/lib/src/cloud.dart to show query attempts and elapsed time.
|
/gcbrun |
|
I don't think we should add print statements in the tests. At most |
oh I know. Just doing it now to debug. will remove! |
…ntries - In test_utils/lib/src/cloud.dart, avoid printing the raw filter string to stdout during polling, which was getting ingested by Cloud Logging in Cloud Build and causing textPayload queries to match Cloud Build's own output. - In pkgs/google_cloud_shelf/test/logging_test.dart, query textPayload for 'structured logging' because GCP Cloud Logging maps structured logs with only a message string to textPayload. - In generated/google_cloud_logging_v2/test/write_log_test.dart, use waitForLogs instead of a brittle 15-second fixed delay.
Use printOnFailure from package:test in waitForLogs so full filter and attempt diagnostics are only printed if a test fails, preventing stdout pollution in Cloud Logging on success.
|
/gcbrun |
…in tearDown - Add a 2-minute timeout to the LoggingServiceV2 test group so waitForLogs has sufficient time to complete under normal Cloud Logging indexing latency. - Catch and ignore NotFoundException in writeLogEntries tearDown.
|
/gcbrun |
kevmoo
changed the title
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request improves test reliability and logging. It adds timeouts to test groups, replaces hardcoded delays with retry-based log polling, and pins the gapic-showcase version. Feedback is provided on the waitForLogs implementation, suggesting the use of a Stopwatch instead of DateTime.now() to ensure monotonic time measurement and to accurately capture the duration of the final successful API call.
Use Stopwatch to track elapsed polling time monotonically and ensure the final API call duration is included in diagnostic logs.
|
/gcbrun |
2 participants
Fixes CI failures across GitHub Actions and Cloud Build integration tests:
gapic-showcaseinstallation tov0.40.0in generated/google_cloud_showcase_v1beta1/test/showcase_server.dart (upstreamv0.42.0fails compilation due to an undefined Go TLS identifier).logging servertest group in pkgs/google_cloud_shelf/test/logging_test.dart to account for Cloud Logging ingestion latency.waitForLogswith a 2-minute group timeout, and ignoreNotFoundExceptionduring tearDown log cleanup.waitForLogsusingprintOnFailureso diagnostic details appear on test failures without polluting stdout in passing runs.