feat(storage): support full_object_checksum in AsyncAppendableObjectWriter#17658
Open
chandra-siri wants to merge 8 commits into
Open
feat(storage): support full_object_checksum in AsyncAppendableObjectWriter#17658chandra-siri wants to merge 8 commits into
chandra-siri wants to merge 8 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for CRC32C checksum validation when closing or finalizing an appendable object in AsyncAppendableObjectWriter, along with corresponding unit and system tests. The review feedback suggests several improvements: avoiding log pollution by removing the warning when finalizing without a checksum, omitting the object_checksums field entirely when it is None to prevent empty submessage serialization (and updating unit tests accordingly), and using a more specific exception class in system tests to avoid masking unexpected errors.
… is None" This reverts commit 7a58986.
… in integration tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for verifying
full_object_checksumon finalising/closing appendable object uploads.