feat(gax): support explicit client shutdown - #649
Draft
coryan wants to merge 1 commit into
Draft
Conversation
Add explicit shutdown() to _HTTPClientProtocol, HTTPClientHolder, and _HTTPClient for deterministic resource cleanup.
coryan
marked this pull request as ready for review
September 4, 2026 13:44
chingor13
approved these changes
Sep 4, 2026
| state = nil | ||
| return client | ||
| } | ||
| if let client { |
Contributor
There was a problem hiding this comment.
This (second/third) let looks odd to me, but maybe it's actually correct.
coryan
marked this pull request as draft
September 4, 2026 18:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add explicit shutdown() to _HTTPClientProtocol, HTTPClientHolder, and _HTTPClient for deterministic resource cleanup.
Motived by #647