llgo: xgo-dev - #100
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Review: replace goplus/llgo with xgo-dev/llgo
No blocking issues found. The change is a clean, complete find-and-replace of the LLGo module path, and I confirmed it is consistent across the repository.
Verified
- All three occurrences updated:
README.md:13(compiler link) and the two//go:linknamedirectives atrtype_llgo.go:139andrtype_llgo.go:379. - A repo-wide search for
goplus/llgoreturns zero remaining references, so nothing was missed. linkname_go121.go:13also declares aninterequallinkname, but it targets the standardruntime.interequalunder the!llgobuild tag — correctly left unchanged.go.modis rightly untouched: thexgo-dev/llgopath appears only in//go:linknamedirectives (resolved at LLGo link time under the//go:build llgotag) and a doc link, so it is not a tracked module dependency.
Non-blocking note (informational)
- The two
//go:linknamedirectives now pull unexported runtime symbols (interequal,DirectIfaceData) from a different GitHub org (xgo-devvsgoplus). Because these are cross-module pull-linknames into aninternal/runtime package, correctness depends on the target keeping identical signatures/ABI, and the linkage is not pinned bygo.sum. Ifxgo-dev/llgois the sanctioned successor home of LLGo in the XGo ecosystem, this is a benign rename — worth a quick confirmation of the new repo's ownership/governance before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.