abi: map go1.27 - #102
Conversation
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review: map_go127.go build constraint
Verdict: Looks good. The one-line change adds && !llgo to the build tag, making map_go127.go consistent with its siblings.
What it fixes: type_llgo.go (//go:build llgo) defines its own MapType struct plus the NeedKeyUpdate/HashMightPanic/IndirectKey/IndirectElem methods and map constants. Before this change, an llgo build on a Go 1.27 toolchain would compile both type_llgo.go and map_go127.go, producing duplicate declarations. Adding && !llgo makes the constraints mutually exclusive.
Consistency: map_swiss.go and map_noswiss.go already carry && !llgo; map_go127.go was the sole outlier. After this PR the version-split + llgo-exclusion pattern is uniform across the map family, and the three go-version map files remain mutually exclusive — exactly one map definition applies in every build configuration.
Reviewed for code quality, performance, security, and documentation accuracy — no issues found.
1 participant
No description provided.