feat: Add Azure API Management Certificate - #1147
Merged
Merged
Conversation
hemalshah-gradientedge
requested review from
despock and
jameswiltshire
as code owners
August 3, 2026 11:01
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Azure package with new resource helpers for Azure Monitor autoscale settings and API Management certificates, and wires certificate creation into the AzureRestApi construct with accompanying test/config updates.
Changes:
- Add
AzureMonitorManager.createMonitorAutoscaleSettingsand its associated props/type + tests/config. - Add
AzureApiManagementManager.createCertificateand integrate certificate provisioning intoAzureRestApi. - Add changesets for both new features.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/azure/test/services/monitor-manager.test.ts | Adds autoscale setting coverage and misconfiguration validation tests for monitor manager. |
| packages/azure/test/services/api-management-manager.test.ts | Adds certificate resource coverage + undefined-props error handling test. |
| packages/azure/test/constructs/rest-api.test.ts | Exercises the new APIM certificate creation path in REST API construct flows. |
| packages/azure/test/common/config/rest-api-new-with-cert.json | Adds apiManagementCertificate test config for the “new API with cert” scenario. |
| packages/azure/test/common/config/monitor.json | Adds autoscale setting config used by monitor manager tests. |
| packages/azure/src/services/monitor/types.ts | Introduces MonitorAutoscaleSettingProps. |
| packages/azure/src/services/monitor/main.ts | Implements createMonitorAutoscaleSettings. |
| packages/azure/src/services/api-management/types.ts | Introduces CertificateProps. |
| packages/azure/src/services/api-management/main.ts | Implements createCertificate. |
| packages/azure/src/construct/rest-api/types.ts | Adds apiManagementCertificate to AzureRestApiProps. |
| packages/azure/src/construct/rest-api/main.ts | Adds createApiManagementCertificate() and invokes it in the construct flow. |
| .changeset/twenty-bears-move.md | Changeset entry for monitor autoscale settings. |
| .changeset/full-badgers-remain.md | Changeset entry for APIM certificate support. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
Suppressed comments (2)
packages/azure/src/construct/rest-api/types.ts:40
apiManagementCertificateis declared as a required prop, butcreateApiManagementCertificate()explicitly treats it as optional (early-returns when it’s absent). Making it required is a breaking API change for consumers/configs that don’t define a certificate. Mark this prop optional to match the runtime behavior.
/** API Management certificate properties */
apiManagementCertificate: CertificateProps
packages/azure/test/constructs/rest-api.test.ts:443
- This test doesn’t assert anything beyond what the earlier "synthesises" test already covers, so it won’t catch regressions related to the new APIM certificate flow. Either remove it or update it to validate the newly introduced
apiManagementCertificateconfig/props.
describe('TestRestApiNewApiWithCertConstruct', () => {
test('creates api management certificate flow as expected', () => {
expect(stackNewApiWithCert.construct).toBeDefined()
expect(stackNewApiWithCert.construct.api).toBeDefined()
expect(stackNewApiWithCert.construct.api.apim).toBeDefined()
})
})
despock
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.