Skip to content

feat: Add Azure API Management Certificate - #1147

Merged
hemalshah-gradientedge merged 7 commits into
mainfrom
feat/apim_certificates
Aug 3, 2026
Merged

feat: Add Azure API Management Certificate#1147
hemalshah-gradientedge merged 7 commits into
mainfrom
feat/apim_certificates

Conversation

@hemalshah-gradientedge

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the Azure package with new resource helpers for Azure Monitor autoscale settings and API Management certificates, and wires certificate creation into the AzureRestApi construct with accompanying test/config updates.

Changes:

  • Add AzureMonitorManager.createMonitorAutoscaleSettings and its associated props/type + tests/config.
  • Add AzureApiManagementManager.createCertificate and integrate certificate provisioning into AzureRestApi.
  • Add changesets for both new features.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/azure/test/services/monitor-manager.test.ts Adds autoscale setting coverage and misconfiguration validation tests for monitor manager.
packages/azure/test/services/api-management-manager.test.ts Adds certificate resource coverage + undefined-props error handling test.
packages/azure/test/constructs/rest-api.test.ts Exercises the new APIM certificate creation path in REST API construct flows.
packages/azure/test/common/config/rest-api-new-with-cert.json Adds apiManagementCertificate test config for the “new API with cert” scenario.
packages/azure/test/common/config/monitor.json Adds autoscale setting config used by monitor manager tests.
packages/azure/src/services/monitor/types.ts Introduces MonitorAutoscaleSettingProps.
packages/azure/src/services/monitor/main.ts Implements createMonitorAutoscaleSettings.
packages/azure/src/services/api-management/types.ts Introduces CertificateProps.
packages/azure/src/services/api-management/main.ts Implements createCertificate.
packages/azure/src/construct/rest-api/types.ts Adds apiManagementCertificate to AzureRestApiProps.
packages/azure/src/construct/rest-api/main.ts Adds createApiManagementCertificate() and invokes it in the construct flow.
.changeset/twenty-bears-move.md Changeset entry for monitor autoscale settings.
.changeset/full-badgers-remain.md Changeset entry for APIM certificate support.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/azure/src/construct/rest-api/types.ts
Copilot AI review requested due to automatic review settings August 3, 2026 11:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

Suppressed comments (2)

packages/azure/src/construct/rest-api/types.ts:40

  • apiManagementCertificate is declared as a required prop, but createApiManagementCertificate() explicitly treats it as optional (early-returns when it’s absent). Making it required is a breaking API change for consumers/configs that don’t define a certificate. Mark this prop optional to match the runtime behavior.
  /** API Management certificate properties */
  apiManagementCertificate: CertificateProps

packages/azure/test/constructs/rest-api.test.ts:443

  • This test doesn’t assert anything beyond what the earlier "synthesises" test already covers, so it won’t catch regressions related to the new APIM certificate flow. Either remove it or update it to validate the newly introduced apiManagementCertificate config/props.
describe('TestRestApiNewApiWithCertConstruct', () => {
  test('creates api management certificate flow as expected', () => {
    expect(stackNewApiWithCert.construct).toBeDefined()
    expect(stackNewApiWithCert.construct.api).toBeDefined()
    expect(stackNewApiWithCert.construct.api.apim).toBeDefined()
  })
})

@hemalshah-gradientedge
hemalshah-gradientedge merged commit 9dbf49b into main Aug 3, 2026
9 checks passed
@hemalshah-gradientedge
hemalshah-gradientedge deleted the feat/apim_certificates branch August 3, 2026 13:41
@github-actions github-actions Bot mentioned this pull request Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants