feat: Azure monitor autoscale name consistency - #1152
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make Azure Monitor autoscale setting naming consistent by explicitly setting the Azure Native autoscaleSettingName input (in addition to the existing name) so the resource’s ARM path/name stays aligned, and updating tests/changeset accordingly.
Changes:
- Set a computed
autoscaleSettingNamewhen creatingazure-native:monitor:AutoscaleSetting. - Update Pulumi mocks/tests to read the autoscale name from
args.inputs.autoscaleSettingName. - Add a patch changeset for the Azure package.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/azure/test/services/monitor-manager.test.ts | Updates Pulumi mocks to use autoscaleSettingName for autoscale resources. |
| packages/azure/src/services/monitor/main.ts | Computes and passes autoscaleSettingName (and aligns it with name) when creating autoscale settings. |
| .changeset/bumpy-coins-fetch.md | Adds a patch changeset documenting the autoscale naming fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (1)
packages/azure/test/services/monitor-manager.test.ts:105
- The mock now derives the AutoscaleSetting output name from
autoscaleSettingName, but it no longer verifies that the request payloadnameis kept in sync. Since the production code explicitly sets both to avoid Azure validation failures, the test should fail if they ever diverge (or ifnameis accidentally removed).
if (args.type === 'azure-native:monitor:AutoscaleSetting') {
name = args.inputs.autoscaleSettingName
return {
despock
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.