Skip to content

feat: Azure monitor autoscale name consistency - #1152

Merged
hemalshah-gradientedge merged 2 commits into
mainfrom
feat/monitor-autoscale-name
Aug 5, 2026
Merged

feat: Azure monitor autoscale name consistency#1152
hemalshah-gradientedge merged 2 commits into
mainfrom
feat/monitor-autoscale-name

Conversation

@hemalshah-gradientedge

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to make Azure Monitor autoscale setting naming consistent by explicitly setting the Azure Native autoscaleSettingName input (in addition to the existing name) so the resource’s ARM path/name stays aligned, and updating tests/changeset accordingly.

Changes:

  • Set a computed autoscaleSettingName when creating azure-native:monitor:AutoscaleSetting.
  • Update Pulumi mocks/tests to read the autoscale name from args.inputs.autoscaleSettingName.
  • Add a patch changeset for the Azure package.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/azure/test/services/monitor-manager.test.ts Updates Pulumi mocks to use autoscaleSettingName for autoscale resources.
packages/azure/src/services/monitor/main.ts Computes and passes autoscaleSettingName (and aligns it with name) when creating autoscale settings.
.changeset/bumpy-coins-fetch.md Adds a patch changeset documenting the autoscale naming fix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/azure/src/services/monitor/main.ts
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings August 5, 2026 09:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (1)

packages/azure/test/services/monitor-manager.test.ts:105

  • The mock now derives the AutoscaleSetting output name from autoscaleSettingName, but it no longer verifies that the request payload name is kept in sync. Since the production code explicitly sets both to avoid Azure validation failures, the test should fail if they ever diverge (or if name is accidentally removed).
    if (args.type === 'azure-native:monitor:AutoscaleSetting') {
      name = args.inputs.autoscaleSettingName

      return {

@hemalshah-gradientedge
hemalshah-gradientedge merged commit e2848cb into main Aug 5, 2026
9 checks passed
@hemalshah-gradientedge
hemalshah-gradientedge deleted the feat/monitor-autoscale-name branch August 5, 2026 11:02
@github-actions github-actions Bot mentioned this pull request Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants