feat: commercetools-aligned per-method retry defaults for mutations - #325
Merged
Conversation
…tions POST/PATCH/DELETE mutations are no longer retried on ECONNABORTED/ETIMEDOUT or 500 by default — CT may have already processed the mutation server-side. Gateway errors (502/503/504) are still retried as the LB rejected the request before forwarding to CT. Changes: - types.ts: add MethodRetryPolicy interface and methodPolicies to CommercetoolsRetryConfig - is-retryable-error.ts: method-aware logic with CT-aligned per-method defaults - request.ts: pass httpMethod and methodPolicies to isRetryableError - tests: full coverage of new method-aware behavior and backward-compat cases
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (94.11%) is below the target coverage (99.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
==========================================
- Coverage 99.31% 99.25% -0.07%
==========================================
Files 58 58
Lines 1456 1470 +14
Branches 148 156 +8
==========================================
+ Hits 1446 1459 +13
Misses 2 2
- Partials 8 9 +1
🚀 New features to boost your workflow:
|
jimmythomson
approved these changes
Jun 17, 2026
|
🎉 This PR is included in version 6.28.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST/PATCH/DELETE mutations are no longer retried on ECONNABORTED/ETIMEDOUT or 500 by default — commercetools may have already processed the mutation server-side. Gateway errors (502/503/504) are still retried as the LB rejected the request before forwarding to commercetools.
Changes: