Icon Marker Filters - #152
Closed
gjorgdy wants to merge 10 commits into
Closed
Conversation
Downgraded adventure version from 5.0.0-SNAPSHOT to 4.25.0.
granny
requested changes
May 21, 2026
granny
left a comment
granny
left a comment
Owner
There was a problem hiding this comment.
I'm not sure how I feel about hardcoding css styles.. this would probably work fine, but what do you think about introducing a single String variable for inline css styling?
granny
reviewed
May 21, 2026
Contributor
Author
As far as I understand Leaflet does not easily allow custom CSS, otherwise I would've done it that way. They only allow custom class names. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a bit more control over the look of icon markers I have added a few 'filters' using some SCSS tricks.
All of them have the same functions like the existing options of icon markers.
It should also be pretty easy to add more custom CSS attributes to this in the future.
built behind #151