fix: Portfolio ID collision — use incrementing nonce instead of ledger sequence - #60

Merged

Uchechukwu-Ekezie merged 10 commits into

grantFoxin:mainfrom

brightcli-stack:fix/portfolio-id-collision

Aug 22, 2026

Commits on Aug 20, 2026

add PortfolioCount variant to DataKey enum
brightcli-stack
committed
8995d34

Commits on Aug 21, 2026

switch portfolio ID from ledger sequence to incrementing nonce
brightcli-stack
committed
0880eaa
add test for two users creating portfolios in same ledger
brightcli-stack
committed
91ef7ff
bump soroban-sdk to 21.7.7 for test compatibility
brightcli-stack
committed
a7b9747
approach decision: nonce over SHA-256 for ID generation
brightcli-stack
committed
f629057
note: existing portfolio IDs are unaffected
brightcli-stack
committed
f92aa62
test coverage: both acceptance criteria now tested
brightcli-stack
committed
bdaf28c
why not use SHA-256 despite the issue recommending it
brightcli-stack
committed
40377e0
storage implications of the nonce approach
brightcli-stack
committed
06c415a
performance considerations
brightcli-stack
committed
aa76ef5