Skip to content

Better ribbon.alpha for "dark" theme #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grantmcdermott merged 1 commit into from
May 31, 2026
+7 −4
Merged

Better ribbon.alpha for "dark" theme #603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,10 @@ visualizations.
- **Theme refinements**. The `"tufte"` and `"void"` themes are now dynamic
(responsive margins). The `"ipsum"` theme has been overhauled (bold title, no
ticks, fine grid, custom palette); the original variant is preserved as
`"ipsum2"`. The `"bw"` and `"classic"` themes now use smaller axis text and
tighter spacing to better match their ggplot2 counterparts.
(#595 @grantmcdermott)
`"ipsum2"`. The ggplot2-inspired like `"bw"` and `"classic"` now use smaller
axis text and tighter spacing to better match their ggplot2 counterparts.
Also, the `"dark"` theme now uses a better default `ribbon.alpha` for better
contrast against the black background. (#595, #603 @grantmcdermott)

### New features

Expand Down
4 changes: 3 additions & 1 deletion R/tinytheme.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ theme_default = list(
# palette.qualitative = "R4",
# palette.sequential = "Viridis",
pch = par("pch"), # 1,
ribbon.alpha = 0.2,
side.sub = 1,
tck = NA,
tcl = par("tcl"), # -0.5
Expand Down Expand Up @@ -480,7 +481,8 @@ theme_dark = modifyList(theme_minimal, list(
# facet.bg = "gray20",
grid.col = "#6D6D6D",
palette.qualitative = "Set 2",
palette.sequential = "Sunset"
palette.sequential = "Sunset",
ribbon.alpha = 0.5
))

# derivatives of clean/clean2
Expand Down
Loading