ci: fix release pipeline — update actions, add GH releases, extend CI triggers#1956
Merged
ci: fix release pipeline — update actions, add GH releases, extend CI triggers#1956
Conversation
… triggers - Update actions/checkout and actions/setup-node to v6 in release.yml and hotfix.yml (Node.js 24 compat, prevents June 2026 breakage) - Add GitHub Release creation to release finalize, release RC, and hotfix finalize steps (populates Releases page automatically) - Extend test.yml push triggers to release/** and hotfix/** branches - Extend security-scan.yml PR triggers to release/** and hotfix/** branches Closes #1955 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2 tasks
trek-e
commented
Apr 10, 2026
Collaborator
Author
trek-e
left a comment
There was a problem hiding this comment.
Review — ci: fix release pipeline
All checks pass. The changes are correct and complete.
Action version pins
actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd— verified as the lightweight commit SHA for v6.0.2 via GitHub API. Correct.actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f— verified as the lightweight commit SHA for v6.3.0 via GitHub API. Correct.
GitHub Release steps
hotfix finalize: createsv${VERSION} (hotfix)release with--generate-notes. Correct.release rc: createsv${PRE_VERSION}pre-release with--generate-notes --prerelease. Correct.release finalize: createsv${VERSION}release with--generate-notes --latest. Correct —--latestis appropriate for stable releases only.- All three steps are gated on
${{ !inputs.dry_run }}— dry_run mode is clean. GH_TOKEN: ${{ github.token }}is bound viaenv:— no shell injection vector.
CI trigger extensions
Adding release/** and hotfix/** to test.yml push triggers and security-scan.yml PR triggers is correct — these branches must have CI coverage during their active development window.
No issues found. Ready to merge.
Collaborator
Author
|
Ready to merge — 2026-04-10 All CI checks pass (test matrix Ubuntu/macOS × Node 22/24, security scan, PR gate, issue link, branch name). The diff is clean:
No new issues found. This is pending maintainer merge only. The post-merge admin checklist in the PR body (repo permissions, environment secrets, branch protection) must be completed before the release pipeline will fully function. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1955
actions/checkout(v4.2.2 → v6.0.2) andactions/setup-node(v4.1.0 → v6.3.0) inrelease.ymlandhotfix.yml— prevents Node.js 20 deprecation breakage after June 2, 2026gh release createsteps to release RC, release finalize, and hotfix finalize — populates GitHub Releases page automaticallytest.ymlpush triggers torelease/**andhotfix/**branchessecurity-scan.ymlPR triggers torelease/**andhotfix/**branchesMAINTAINER MERGE ONLY
This PR requires manual repo admin steps before the release pipeline will fully work. These code changes are necessary but not sufficient — the blocker is a repo setting, not code.
Post-Merge Admin Checklist
After merging this PR, the repo admin must complete these steps:
GraphQL: GitHub Actions is not permitted to create or approve pull requests)test,security,check-issue-link), block force pushrelease/*,hotfix/*,mainNPM_TOKENas environment secretNPM_TOKEN(after environment secret is confirmed working)finalizefor version1.34.0(never published due to PR permission blocker)finalizefor version1.33.1(never published due to PR permission blocker)release/1.34.0,hotfix/1.33.1Full analysis:
CI-CD-PIPELINE-REPORT.mdin repo root (not committed — local reference only).Test plan
npm run test:coverage— 2700+ tests, all green)dry_run: truedry_run: true🤖 Generated with Claude Code