fix(config): allow intel.enabled in config-set whitelist#2021
fix(config): allow intel.enabled in config-set whitelist#2021trek-e merged 1 commit intogsd-build:mainfrom
Conversation
`intel.enabled` is the documented opt-in for the intel subsystem (see commands/gsd/intel.md and docs/CONFIGURATION.md), but it was missing from VALID_CONFIG_KEYS in config.cjs, so the canonical command failed: $ gsd-tools config-set intel.enabled true Error: Unknown config key: "intel.enabled" Add the key to the whitelist, document it under a new "Intel Fields" section in planning-config.md alongside the other namespaced fields, and cover it with a config-set test. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
trek-e
left a comment
There was a problem hiding this comment.
Review
Blocking: Missing required issue link
Per CONTRIBUTING.md, every fix PR must have a confirmed bug issue with a closing keyword (Closes #NNN, Fixes #NNN, or Resolves #NNN) in the PR body. No issue number appears in this PR description.
Please:
- Open a bug issue for this regression (config-set rejecting
intel.enableddespite it being a documented config key) - Add
Fixes #NNNto this PR body once the issue is created
Code review (no code issues found)
The fix itself is correct and minimal:
- Adding
intel.enabledtoVALID_CONFIG_KEYSis the right approach - The Intel Fields documentation section in
planning-config.mdfollows the same format as other sections - The test uses
writeConfig+runGsdTools+readConfig— correct pattern per CONTRIBUTING.md loadConfigderivesKNOWN_TOP_LEVELfromVALID_CONFIG_KEYS, so no other changes are needed
Once the issue link is added, this is ready to merge.
|
Second-pass verified — 2026-04-10 No new concerns. The original blocking issue stands: this PR has no linked bug issue with a closing keyword in the body. The fix itself is correct. Once a bug issue is filed and |
trek-e
left a comment
There was a problem hiding this comment.
The only blocker from the previous review — missing issue link — is resolved: Fixes #2047 is now in the PR body.
The fix is correct: intel.enabled added to VALID_CONFIG_KEYS, Intel Fields section documented in planning-config.md, regression test covers the config-set round-trip. Approving for merge.
Fixes #2047
Summary
intel.enabledis the documented opt-in for the intel subsystem (commands/gsd/intel.md,docs/CONFIGURATION.md,docs/FEATURES.md) but it was missing fromVALID_CONFIG_KEYSinget-shit-done/bin/lib/config.cjs, so the canonical enablement command failed:Adds
intel.enabledto the whitelist, documents it under a new "Intel Fields" section inreferences/planning-config.md(matching the pattern from docs(config): document missing config keys in planning-config.md #1947), and covers it with aconfig-settest.loadConfigincore.cjsderivesKNOWN_TOP_LEVELfromVALID_CONFIG_KEYS, so the newinteltop-level namespace is accepted automatically with no additional changes.Test plan
node --test tests/config.test.cjs— all 65 tests pass, including newsets intel.enabled to opt into the intel subsystemcasenode --test tests/config-field-docs.test.cjs tests/intel.test.cjs— passes