Improve performance of openeing files. - #6
Open
dncnmcdougall wants to merge 11 commits into
Open
Conversation
…es a data structer that is slightly faster to process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update works to improve the reading performance of large files.
See #5.
It does this simply by reading the sqlite databases in a lazy manner.
This also provdes some utilities, like
join_frameandrangeon theanalyseobject that can be used for more complex queries.In particular
join_framecan be used to join another table to the Frames table along the Frame Id.For example when reading MALDI data using
frame_info = tof_data.analysis.join_frame("MaldiFrameInfo")gives the frame infor and the x and y all at the same time, reducing iteration complexity.Secondly this adds the
tims_read_scans_v2_as_arraymethod which returns the results as a single numpy array. This is slightly faster thantims_read_scans_v2and yields the data in a manner that is potentially faster for processing.Unfortunately this PR also has a lot of collateral changes: