Skip to content

Add multimedia slideshow atom - #228

Merged
Georges-GNM merged 3 commits into
mainfrom
gl/spike-multimedia-atom
Sep 9, 2026
Merged

Georges-GNM merged 3 commits into
mainfrom
gl/spike-multimedia-atom

Conversation

@Georges-GNM

@Georges-GNM Georges-GNM commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Introduces the shape of a multimedia slideshow atom to the content atom model, based on the requirements defined in this google doc.

The slide can be either an image (using the existing image type), or a media atom id, which should be sufficient information to store in the atom and enable platforms to look up the data.

Part of https://github.com/guardian/eventkit-mission/issues/58

This has been used in various draft/spike PRs, and tested further down the pipeline by being able to store and retrieve a multimedia slideshow created in atom workshop in a local CAPI branch.

@Georges-GNM Georges-GNM changed the title spike multimedia atom spike multimedia slideshow atom Jul 30, 2026
gu-scala-library-release Bot added a commit that referenced this pull request Aug 3, 2026
…ished by Georges-GNM

Georges-GNM published release version 13.1.0-PREVIEW.glspike-multimedia-atom.2026-08-03T1406.314057f2
using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow

Release-Version: 13.1.0-PREVIEW.glspike-multimedia-atom.2026-08-03T1406.314057f2
Release-Initiated-By: https://github.com/Georges-GNM
Release-Workflow-Run: https://github.com/guardian/content-atom/actions/runs/30821043266
Release-Notes: #228
@gu-scala-library-release

Copy link
Copy Markdown
Contributor

@Georges-GNM has published a preview version of this PR with release workflow run #73, based on commit 314057f:

13.1.0-PREVIEW.glspike-multimedia-atom.2026-08-03T1406.314057f2

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the gl/spike-multimedia-atom branch, or use the GitHub CLI command:

gh workflow run release.yml --ref gl/spike-multimedia-atom

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

Comment thread thrift/src/main/thrift/atoms/multimediaslideshow.thrift
Comment thread thrift/src/main/thrift/atoms/multimediaslideshow.thrift
Comment thread thrift/src/main/thrift/atoms/multimediaslideshow.thrift
@Georges-GNM
Georges-GNM force-pushed the gl/spike-multimedia-atom branch from 314057f to c8b18f8 Compare September 1, 2026 22:36
gu-scala-library-release Bot added a commit that referenced this pull request Sep 1, 2026
…ished by Georges-GNM

Georges-GNM published release version 15.1.0-PREVIEW.glspike-multimedia-atom.2026-09-01T2238.c8b18f89
using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow

Release-Version: 15.1.0-PREVIEW.glspike-multimedia-atom.2026-09-01T2238.c8b18f89
Release-Initiated-By: https://github.com/Georges-GNM
Release-Workflow-Run: https://github.com/guardian/content-atom/actions/runs/33567309405
Release-Notes: #228
@gu-scala-library-release

Copy link
Copy Markdown
Contributor

@Georges-GNM has published a preview version of this PR with release workflow run #77, based on commit c8b18f8:

15.1.0-PREVIEW.glspike-multimedia-atom.2026-09-01T2238.c8b18f89

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the gl/spike-multimedia-atom branch, or use the GitHub CLI command:

gh workflow run release.yml --ref gl/spike-multimedia-atom

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

@Georges-GNM Georges-GNM added the feature Departmental tracking: work on a new feature label Sep 8, 2026
@Georges-GNM Georges-GNM self-assigned this Sep 8, 2026
@Georges-GNM Georges-GNM changed the title spike multimedia slideshow atom Add multimedia slideshow atom Sep 9, 2026
@Georges-GNM
Georges-GNM marked this pull request as ready for review September 9, 2026 08:32
@Georges-GNM
Georges-GNM requested review from a team as code owners September 9, 2026 08:32
@emdash-ie

Copy link
Copy Markdown
Contributor

Would you mind updating the round-trip tests to cover this type as well? The thriftToFile helper should get you started, and I can pair if you’d like a hand!

@Georges-GNM
Georges-GNM merged commit c7c1f49 into main Sep 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Departmental tracking: work on a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants