Skip to content

Add new spacefinder data attribute to allow disabling spacefinder - #16692

Draft
cemms1 wants to merge 2 commits into
mainfrom
cemms1/disable-spacefinder
Draft

cemms1 wants to merge 2 commits into
mainfrom
cemms1/disable-spacefinder

Conversation

@cemms1

@cemms1 cemms1 commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

What does this change?

Adds support for a new data attribute to be included in the article body to signal that spacefinder should be disabled for a particular article

Why?

This is intended to be used for certain interactive articles that are incompatible with Spacefinder and will insert their own ads manually

@cemms1 cemms1 added the feature Departmental tracking: work on a new feature label Sep 7, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

🚀 Image pushed to AWS ECR

Image digest: sha256:2357682c49e8f6955fa329dff9fb39159dba3878eef65602b579c20dab20d53f

🐛 Run the image locally

The following can be used to run the image locally:

# Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:2357682c49e8f6955fa329dff9fb39159dba3878eef65602b579c20dab20d53f"

# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-cemms1-disable-spacefinder"

# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-30910"

# Refer to image via the GitHub commit SHA tag
# IMAGE_IDENTIFIER=":sha-a431dbf9afe3c1736aabdadbbb00d65540bd673f"

# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"

IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/deployTools --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering${IMAGE_IDENTIFIER}"

# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY

# Pull the image
docker pull $IMAGE

# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE

From guardian/actions-publish-image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Departmental tracking: work on a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant