Skip to content

Update Labs immersive main media and typography #16707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DanielCliftonGuardian wants to merge 7 commits into
base: main
Choose a base branch
from
+45 −9
Open

Update Labs immersive main media and typography #16707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
47fe887
Update Labs immersive main media and typography
DanielCliftonGuardian Sep 9, 2026
0efe7fc
Merge branch 'main' into labs-immersive-updates
DanielCliftonGuardian Sep 10, 2026
b4df25e
Fixed height below desktop only
DanielCliftonGuardian Sep 14, 2026
d80b7c2
Merge branch 'main' into labs-immersive-updates
DanielCliftonGuardian Sep 14, 2026
446f101
Set 469px as minimum height not fixed
DanielCliftonGuardian Sep 14, 2026
f6c5b31
Merge branch 'main' into labs-immersive-updates
DanielCliftonGuardian Sep 14, 2026
695f3f2
Update StandardLayoutArticleGrid.tsx
DanielCliftonGuardian Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions dotcom-rendering/src/components/Standfirst.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,15 @@ export const Standfirst = ({ format, standfirst, layoutType }: Props) => {
layoutType?.startsWith('immersive')
? immersiveGridOverrides
: undefined,
layoutType?.startsWith('immersive') === true &&
format.theme === ArticleSpecial.Labs &&
css`
font-weight: 500;

${from.tablet} {
font-weight: 500;
}
Comment thread
DanielCliftonGuardian marked this conversation as resolved.
`,
]}
className={
format.design === ArticleDesign.Interactive
Expand Down
45 changes: 36 additions & 9 deletions dotcom-rendering/src/layouts/StandardLayoutArticleGrid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ const stretchLines = css`
const immersiveMediaBelowDesktop = (
headlineBackground: string,
isMainMediaImage: boolean,
hasMinimumImageHeight: boolean,
) => css`
${until.desktop} {
position: relative;
Expand All @@ -78,18 +79,24 @@ const immersiveMediaBelowDesktop = (
position: absolute;
left: 0;
right: 0;
bottom: 0;
height: ${isMainMediaImage
? 'min(60%, calc(200% - 120vw + 30px))'
: 'min(60%, 144px)'};
bottom: ${hasMinimumImageHeight ? '-1px' : '0'};
height: ${hasMinimumImageHeight
? '180px'
: isMainMediaImage
? 'min(60%, calc(200% - 120vw + 30px))'
: 'min(60%, 144px)'};
z-index: ${getZIndex('mediaOverlay')};
background: linear-gradient(
to bottom,
rgba(0, 0, 0, 0.08),
${headlineBackground} 72%
rgba(0, 0, 0, ${hasMinimumImageHeight ? '0' : '0.08'}),
${headlineBackground} ${hasMinimumImageHeight ? '100%' : '72%'}
);
backdrop-filter: blur(12px);
mask-image: linear-gradient(to bottom, transparent 40%, black 60%);
mask-image: linear-gradient(
to bottom,
transparent ${hasMinimumImageHeight ? '0%' : '40%'},
black 60%
);
pointer-events: none;
}
}
Expand Down Expand Up @@ -185,6 +192,7 @@ export const StandardLayoutArticleGrid = ({
const isMainMediaImage =
mainMedia?._type ===
'model.dotcomrendering.pageElements.ImageBlockElement';
const hasMinimumImageHeight = isLabs && isImmersive && isMainMediaImage;
const mainMediaUrl: string | undefined = isMainMediaImage
? mainMedia.media.allImages[0]?.url
: undefined;
Expand All @@ -197,7 +205,7 @@ export const StandardLayoutArticleGrid = ({
const immersiveHeaderHeight =
minHeaderHeightPx + (isLabs ? LABS_HEADER_HEIGHT : 0);
const immersiveMediaRowHeight = isMainMediaImage
? '60vw'
? 'auto'
: `max(calc(80vh - ${immersiveHeaderHeight}px), calc(25rem - ${immersiveHeaderHeight}px))`;

const layoutType = getLayoutType({
Expand Down Expand Up @@ -233,7 +241,6 @@ export const StandardLayoutArticleGrid = ({
)};
}
}
/* Anchor the title consistently while wrapped text extends the media below it. */
grid-template-rows: ${immersiveMediaRowHeight} repeat(
6,
auto
Expand Down Expand Up @@ -279,7 +286,27 @@ export const StandardLayoutArticleGrid = ({
${immersiveMediaBelowDesktop(
headlineBackgroundImmersive,
isMainMediaImage,
hasMinimumImageHeight,
)}

${hasMinimumImageHeight &&
css`
${until.desktop} {
position: relative;
width: 100%;
min-width: 0;
min-height: 469px;
${mainMediaAspectRatio != null &&
`aspect-ratio: ${mainMediaAspectRatio.replace(':', ' / ')};`}
overflow: hidden;
background-color: ${headlineBackgroundImmersive};

> div {
position: absolute;
inset: 0;
}
}
`}
`
: undefined
}
Expand Down
Loading