Skip to content

Clarify getElectionData - #16712

Merged
JamieB-gu merged 1 commit into
mainfrom
clarify-get-election-data
Sep 14, 2026
Merged

JamieB-gu merged 1 commit into
mainfrom
clarify-get-election-data

Conversation

@JamieB-gu

Copy link
Copy Markdown
Contributor

To make it clearer why it's being passed in, and why the type is unknown.

Requested by @alexduf #16690 (comment)

To make it clearer why it's being passed in, and why the type is
`unknown`.
@JamieB-gu
JamieB-gu requested a review from alexduf September 10, 2026 16:26
@JamieB-gu JamieB-gu self-assigned this Sep 10, 2026
@JamieB-gu JamieB-gu added the maintenance Departmental tracking: maintenance work, not a fix or a feature label Sep 10, 2026
@github-actions

Copy link
Copy Markdown

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@github-actions

Copy link
Copy Markdown

🚀 Image pushed to AWS ECR

Image digest: sha256:18d2d57d701b3de11aa9642d75b0e5eeaa474b3f800c07aa436c26c82398a00d

🐛 Run the image locally

The following can be used to run the image locally:

# Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:18d2d57d701b3de11aa9642d75b0e5eeaa474b3f800c07aa436c26c82398a00d"

# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-clarify-get-election-data"

# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-31017"

# Refer to image via the GitHub commit SHA tag
# IMAGE_IDENTIFIER=":sha-4cfecd0d6fe951a254ab83a0727a1762c84977dc"

# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"

IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering${IMAGE_IDENTIFIER}"

# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY

# Pull the image
docker pull $IMAGE

# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE

From guardian/actions-publish-image.

@JamieB-gu JamieB-gu added the run_chromatic Runs chromatic when label is applied label Sep 14, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Sep 14, 2026
@JamieB-gu
JamieB-gu added this pull request to the merge queue Sep 14, 2026
Merged via the queue into main with commit 9680460 Sep 14, 2026
37 checks passed
@JamieB-gu
JamieB-gu deleted the clarify-get-election-data branch September 14, 2026 12:04
@gu-prout

gu-prout Bot commented Sep 14, 2026

Copy link
Copy Markdown

Seen on PROD (merged by @JamieB-gu 11 minutes and 22 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Departmental tracking: maintenance work, not a fix or a feature Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants