Mobile above nav test - Suppress RR banner on variant2. - #16717
Closed
oliverabrahams wants to merge 23 commits into
Closed
oliverabrahams wants to merge 23 commits into
oliverabrahams wants to merge 23 commits into
Conversation
For ease of finding slot for other code Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
# Conflicts: # ab-testing/config/abTests.ts # dotcom-rendering/src/layouts/CrosswordLayout.tsx # dotcom-rendering/src/layouts/FrontLayout.tsx # pnpm-lock.yaml
🚀 Image pushed to AWS ECRImage digest: 🐛 Run the image locallyThe following can be used to run the image locally: # Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:47e273eea22471c52a6c1e16fe94631caf74b92a596739432cee1daa0f26b74c"
# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-oa-mobile-above-nav"
# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-31104"
# Refer to image via the GitHub commit SHA tag
# IMAGE_IDENTIFIER=":sha-c2c9841bdbcf1cdf6cfcf8b6c54f1e480a8fef73"
# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"
IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering${IMAGE_IDENTIFIER}"
# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY
# Pull the image
docker pull $IMAGE
# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Both variants are only for 2 types of pages.
https://github.com/guardian/content-api-scala-client/blob/ed83e958d5ebff2b3aa418dfeb2450236b68109c/client/src/main/scala/com.gu.contentapi.client/utils/CapiModelEnrichment.scala#L123
variant2for variant2 we do not show the RR sticky bottom banner.Why?
How has this change been tested?
Screenshots