Skip to content

Add mobile inline advertising to the Puzzles hub - #16718

Merged
DanielCliftonGuardian merged 1 commit into
mainfrom
Add-mobile-inline-advertising-to-the-Puzzles-hub
Sep 15, 2026
Merged

DanielCliftonGuardian merged 1 commit into
mainfrom
Add-mobile-inline-advertising-to-the-Puzzles-hub

Conversation

@DanielCliftonGuardian

@DanielCliftonGuardian DanielCliftonGuardian commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

What does this change?

Adds mobile inline adverts at the Puzzles hub’s existing blueprint defined ad placements, reusing the mobile-front component alongside desktop banners.

Updates tests to verify real slot markup, unique desktop and mobile IDs, invalid slot declarations and ad-free suppression.

Why?

Parity with figma designs https://www.figma.com/design/pRGn7NmhCQXuoq7B6XhVov/Puzzles-Ad-Slots?node-id=5744-15711&t=SSFUMwkAnXJV6eZO-0

How has this change been tested?

@github-actions

Copy link
Copy Markdown

🚀 Image pushed to AWS ECR

Image digest: sha256:ecff830f62f78194d4e07cc7deb63adcb310618cfc6b53bfb3be3084417c273c

🐛 Run the image locally

The following can be used to run the image locally:

# Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:ecff830f62f78194d4e07cc7deb63adcb310618cfc6b53bfb3be3084417c273c"

# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-Add-mobile-inline-advertising-to-the-Puzzles-hub"

# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-31105"

# Refer to image via the GitHub commit SHA tag
# IMAGE_IDENTIFIER=":sha-d7aa4be9836cb66d28160fc71020be27dfc9891d"

# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"

IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering${IMAGE_IDENTIFIER}"

# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY

# Pull the image
docker pull $IMAGE

# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE

From guardian/actions-publish-image.

@DanielCliftonGuardian DanielCliftonGuardian self-assigned this Sep 14, 2026
@DanielCliftonGuardian DanielCliftonGuardian added the feature Departmental tracking: work on a new feature label Sep 14, 2026

@gustavo-olmedo gustavo-olmedo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DanielCliftonGuardian
DanielCliftonGuardian marked this pull request as ready for review September 15, 2026 09:59
@DanielCliftonGuardian DanielCliftonGuardian added the run_chromatic Runs chromatic when label is applied label Sep 15, 2026
@DanielCliftonGuardian
DanielCliftonGuardian requested a review from a team September 15, 2026 10:00
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Sep 15, 2026
@DanielCliftonGuardian
DanielCliftonGuardian added this pull request to the merge queue Sep 15, 2026
Merged via the queue into main with commit 7274a58 Sep 15, 2026
40 of 42 checks passed
@DanielCliftonGuardian
DanielCliftonGuardian deleted the Add-mobile-inline-advertising-to-the-Puzzles-hub branch September 15, 2026 11:10
@gu-prout

gu-prout Bot commented Sep 15, 2026

Copy link
Copy Markdown

Seen on PROD (merged by @DanielCliftonGuardian 8 minutes ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Departmental tracking: work on a new feature Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants