Sentry Improvements - #4829
Open
AlexAscherson wants to merge 4 commits into
Open
Conversation
NB. Requires new env vars
Fx collision with shared config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Note: New env vars required for reporting - no failure if not present
For sourcemaps:
SENTRY_AUTH_TOKEN
SENTRY_ORG
SENTRY_PROJECT
SENTRY_RELEASE currently set to github.sha in ci.yml
For scala sentry coverage:
sentry.enabled
sentry.dsn
sentry.environment
are required in CommonConfig.scala / defaults in application.conf
How should a reviewer test this change?
How can success be measured?
Who should look at this?
Tested? Documented?