Skip to content

Run go reviews in fresh Claude and Codex processes - #218

Merged
haacked merged 5 commits into
mainfrom
haacked/go-harness-review
Sep 24, 2026
Merged

haacked merged 5 commits into
mainfrom
haacked/go-harness-review

Conversation

@haacked

@haacked haacked commented Sep 24, 2026

Copy link
Copy Markdown
Owner
  • go runs /review-code --fix in a fresh process of the active harness, using Claude Code or Codex as appropriate. It saves review state and a validated result under the worktree's .notes/ directory so the parent can resume after a context clear.
  • Each attempt keeps its sessions, reports, temporary worktrees, and hook files under .notes/go-reviews/. After validation, the parent archives the report in shared review history.
  • Codex installs go and uses its own bounded CI route. Its review child keeps native sandbox permissions and has no write grant to shared review caches.

Depends on haacked/review-code#171. The installed review-code skill must support REVIEW_CODE_REVIEW_DIR before the fresh review runner can start.

Test plan

  • Passed 38 runner tests, 30 skill spec checks, 5 canonical skill checks, 75 installer checks, portable skill checks, Ruff, and git diff --check.
  • A find-only smoke test passed with Claude Code and the app-bundled Codex CLI. A full review and fix cycle has not been run.

@haacked
haacked requested a lite review from Copilot September 24, 2026 17:19
@haacked
haacked marked this pull request as ready for review September 24, 2026 17:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Unresolved critical and moderate issues affect Claude compatibility, fix execution, path safety, and test coverage.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 4 High severity · 2 Medium severity

Open (6)
What changed in this PR

Adds fresh Claude/Codex review execution for /go, including resumable state, isolated artifacts, Codex support, and expanded testing.

Changes:

  • Adds the fresh-process review runner and tests.
  • Updates /go documentation and Codex CI guidance.
  • Enables Codex installation and CI coverage.
File Review summary
ai/​tests/​test-ai-installers.sh Installer coverage reviewed; no final comments.
ai/​skills/​go/​SKILL.md Critical (1 vote): Commands at lines 284 and 291 resolve the runner from the implementation worktree instead of the installed skill path.
ai/​skills/​go/​scripts/​tests/​test_run_review.py Moderate (1 vote): The symlink test does not target the randomized temporary file actually opened by save_in_directory.
ai/​skills/​go/​scripts/​run-review.py Critical: unsupported Claude option (1 vote); missing Codex workspace-write sandbox (1 vote); unsafe pre-existing .notes symlink handling (1 vote). Moderate: hard-coded Codex install lookup (2 votes); hard-coded Codex archive destination (2 votes).
ai/​skills/​go/​references/​codex-ci.md Codex CI guidance reviewed; no final comments.
ai/​README.md Documentation reviewed; no final comments.
ai/​codex/​excluded-skills.txt Codex skill configuration reviewed; no final comments.
.github/​workflows/​test.yml CI workflow reviewed; no final comments.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread ai/skills/go/SKILL.md Outdated
Comment thread ai/skills/go/scripts/run-review.py
Comment thread ai/skills/go/scripts/run-review.py
Comment thread ai/skills/go/scripts/run-review.py Outdated
Comment thread ai/skills/go/scripts/run-review.py Outdated
Comment thread ai/skills/go/scripts/run-review.py Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Unresolved critical and moderate findings affect artifact safety, permissions, and review correctness.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 High severity · 1 Medium severity

Open (2)
Resolved since last review (6)
Previously missed (1)

In code that hasn't changed since last review

Medium severity Configure Claude permissions for noninteractive review execution

ai/​skills/​go/​scripts/​run-review.py:171

--permission-prompts none makes any Claude tool call that is not already allowed by the user's permission configuration fail immediately instead of prompting. Since this process must run the full review and apply --fix, a normal/default Claude configuration can leave the child with no ability to run the review scripts or edit the checkout, while the prompt below says to keep normal permission checks and the existing noninteractive review path does not force this flag (bin/run-pr-reviews.sh:709-710). Please use an explicit noninteractive permission configuration that grants only the review's required operations, or do not start the child when that configuration is unavailable.

Comment thread ai/skills/go/scripts/run-review.py Outdated
Comment on lines +143 to +146
review_file = Path(state.get("review_file", ""))
state["artifact_valid"] = review_file.is_file() and hashlib.sha256(
review_file.read_bytes()
).hexdigest() == state.get("review_sha256")
Comment thread ai/skills/go/scripts/run-review.py Outdated
Comment on lines +220 to +222
candidates = [Path.home() / ".agents" / "skills" / "review-code"]
if harness == "claude":
candidates.append(Path.home() / ".claude" / "skills" / "review-code")
@haacked
haacked merged commit a3b5311 into main Sep 24, 2026
1 check passed
@haacked
haacked deleted the haacked/go-harness-review branch September 24, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants