Skip to content

Auto-commit address-pr-reviews fixes with a descriptive message - #220

Merged
haacked merged 2 commits into
mainfrom
haacked/better-address-pr-commit-message
Sep 24, 2026
Merged

haacked merged 2 commits into
mainfrom
haacked/better-address-pr-commit-message

Conversation

@haacked

@haacked haacked commented Sep 24, 2026

Copy link
Copy Markdown
Owner
  • address-pr-reviews commits its fixes without asking. The subject says what the code change does, and a run with several fixes gets one body line per fix. The skill never uses Address PR review feedback or any other subject that names the review instead of the change.
  • The commit names each fixed file, so anything the checkout had staged before the run stays out of it.
  • A new --no-commit flag leaves the fixes staged and skips the push. In attended runs the push still asks first. --unattended and --no-push behave as before.
  • The skill now spells out the held-comment log format itself. It used to point at review-fix-cycle, which a portable sandbox doesn't include.

Test plan

  • test-skill-spec.sh, test-portable-skills.sh, test-portable-skills-lint.sh, test-portable-sync.sh, sync-portable-skills.sh --check, test-plain-writing-contract.sh, test-ai-installers.sh, and the address-pr-reviews test-portable-skill.sh pass.
  • In a scratch repo, git commit -F - -- <paths> committed the named files, including a newly added one, and left another staged file staged.

https://claude.ai/code/session_01AQcAL5wKKpoZUvZMfNgSMa

The skill commits its fixes without asking and writes a subject that says what the code change does. It limits the commit to the fixed files. A new --no-commit flag leaves the fixes staged and skips the push. The push still asks in attended runs.

Claude-Session: https://claude.ai/code/session_01AQcAL5wKKpoZUvZMfNgSMa
@haacked
haacked requested a lite review from Copilot September 24, 2026 21:12
@haacked
haacked marked this pull request as ready for review September 24, 2026 21:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Address mixed staged-hunk isolation and completion tracking for --no-commit.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Medium severity

Open (1)
What changed in this PR

Updates address-pr-reviews to auto-commit fixes with descriptive messages and support staged-only runs.

Changes:

  • Adds --no-commit handling.
  • Defines commit-message and held-comment log formats.
  • Clarifies file scoping and push behavior.
File Summary
ai/​skills/​address-pr-reviews/​SKILL.md Documents updated commit, staging, logging, and push workflows.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread ai/skills/address-pr-reviews/SKILL.md Outdated
@haacked
haacked merged commit 91e9153 into main Sep 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants