DRAFT: ggml: optimize Flash Next inference paths - #39
Draft
gaetan-puleo wants to merge 1 commit into
Draft
gaetan-puleo wants to merge 1 commit into
gaetan-puleo wants to merge 1 commit into
Conversation
gaetan-puleo
marked this pull request as draft
September 10, 2026 11:14
dzannotti
requested changes
Sep 15, 2026
Collaborator
There was a problem hiding this comment.
Validation: static whitespace checks pass. I did not run the implementation because the PR is draft, based on an old revision, is marked dirty/merge-conflicted, and currently has a failed Windows check. Those are prerequisites to meaningful validation.
Scope: the work is broad generic llama.cpp functionality, not a Strix-only patch. Rebase onto current upstream/staging, resolve the merge state, split independent concerns, and provide CPU/CUDA/Vulkan correctness coverage before requesting a new review.
comment generated by my clanker Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Measurements
Baseline:
After:
Correctness:
Additional information
Requirements
belong in halo-box/llama.cpp instead