Skip to content

feat(pi): forward resolved system prompt via --append-system-prompt - #214

Draft
Kunde21 wants to merge 1 commit into
happier-dev:devfrom
Kunde21:pi-system-prompt
Draft

feat(pi): forward resolved system prompt via --append-system-prompt#214
Kunde21 wants to merge 1 commit into
happier-dev:devfrom
Kunde21:pi-system-prompt

Conversation

@Kunde21

@Kunde21 Kunde21 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Resolves the coding system prompt via resolveEffectiveCodingPromptText (providerId: 'pi') in createPiAcpRuntime and forwards it as the --append-system-prompt spawn flag through buildPiRpcArgs, mirroring how the claude backend resolves and forwards its system prompt.

Changes

  • apps/cli/src/backends/pi/acp/runtime.ts / backend.ts: resolve + forward the coding system prompt.
  • apps/cli/src/backends/pi/runPi.ts: pass the resolved prompt through.
  • packages/.../createCatalogProviderAcpRuntime.ts: adds a generic async resolveBackendOptions hook.

Draft — opening for early review.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Note

Forward resolved system prompt to Pi process via --append-system-prompt

  • Adds appendSystemPromptText to PiBackendOptions and extends buildPiRpcArgs in backend.ts to append --append-system-prompt to the spawned Pi process args when a non-blank value is provided.
  • Adds resolveBackendOptions callback support to createCatalogProviderAcpRuntime in createCatalogProviderAcpRuntime.ts, allowing async resolution of backend options before backend construction.
  • In runtime.ts, createPiAcpRuntime now resolves the effective coding system prompt via resolveEffectiveCodingPromptText when credentials are available, passing it as appendSystemPromptText.
  • runPi.ts passes credentials and accountSettings into createPiAcpRuntime to enable the dynamic prompt resolution.
  • Risk: if system prompt resolution fails, the Pi process starts without --append-system-prompt (silent fallback to empty options).

Macroscope summarized cc2d23e. (Automatic summaries will resume when PR exits draft mode or review begins).

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d2362d83-432c-4604-8fc3-c7d7761ecf0b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…claude pattern)

Resolve the coding system prompt with resolveEffectiveCodingPromptText
(providerId: 'pi') in createPiAcpRuntime and forward it as the
--append-system-prompt spawn flag through buildPiRpcArgs, mirroring how
the claude backend resolves and forwards its system prompt. Adds a
generic async resolveBackendOptions hook to createCatalogProviderAcpRuntime.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant