feat(pi): forward resolved system prompt via --append-system-prompt - #214
Draft
Kunde21 wants to merge 1 commit into
Draft
feat(pi): forward resolved system prompt via --append-system-prompt#214Kunde21 wants to merge 1 commit into
Kunde21 wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…claude pattern) Resolve the coding system prompt with resolveEffectiveCodingPromptText (providerId: 'pi') in createPiAcpRuntime and forward it as the --append-system-prompt spawn flag through buildPiRpcArgs, mirroring how the claude backend resolves and forwards its system prompt. Adds a generic async resolveBackendOptions hook to createCatalogProviderAcpRuntime.
Kunde21
force-pushed
the
pi-system-prompt
branch
from
August 4, 2026 06:51
cc2d23e to
b1e9c80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the coding system prompt via
resolveEffectiveCodingPromptText(providerId: 'pi') increatePiAcpRuntimeand forwards it as the--append-system-promptspawn flag throughbuildPiRpcArgs, mirroring how the claude backend resolves and forwards its system prompt.Changes
apps/cli/src/backends/pi/acp/runtime.ts/backend.ts: resolve + forward the coding system prompt.apps/cli/src/backends/pi/runPi.ts: pass the resolved prompt through.packages/.../createCatalogProviderAcpRuntime.ts: adds a generic asyncresolveBackendOptionshook.Draft — opening for early review.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Note
Forward resolved system prompt to Pi process via
--append-system-promptappendSystemPromptTexttoPiBackendOptionsand extendsbuildPiRpcArgsin backend.ts to append--append-system-promptto the spawned Pi process args when a non-blank value is provided.resolveBackendOptionscallback support tocreateCatalogProviderAcpRuntimein createCatalogProviderAcpRuntime.ts, allowing async resolution of backend options before backend construction.createPiAcpRuntimenow resolves the effective coding system prompt viaresolveEffectiveCodingPromptTextwhen credentials are available, passing it asappendSystemPromptText.credentialsandaccountSettingsintocreatePiAcpRuntimeto enable the dynamic prompt resolution.--append-system-prompt(silent fallback to empty options).Macroscope summarized cc2d23e. (Automatic summaries will resume when PR exits draft mode or review begins).