feat: per-profile coding prompt behavior override - #215
Draft
Kunde21 wants to merge 5 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adds CodingPromptBehaviorOverrideV1Schema as an optional nested field on AIBackendProfileSchema, with resolveCodingPromptBehaviorV1WithOverride() and applyCodingPromptBehaviorOverrideToSettings(). Partial semantics: omitted fields inherit the global account default (no per-field defaults). Malformed overrides are dropped via .catch({ v: 1 }) so the profile itself stays valid. Symbols exported from the package barrel.
resolveEffectiveCodingPromptPlan resolves the selected profile by id (non-throwing) and merges its codingPromptBehaviorV1 override over global settings when building the base prompt. Profiles without an override, unknown ids, and built-in profiles fall back to the global default, preserving current behavior.
Derived helper reading a profile's codingPromptBehaviorV1 override (null when absent). Backs the upcoming profile-editor section; pure unit tests cover full, partial, absent, and malformed overrides.
Pure builder that turns explicit per-knob choices into a CodingPromptBehaviorOverrideV1 (or undefined when neither knob is set), preserving omit-means-inherit semantics on save. Unit tests cover partial, full, and null handling.
Adds a profile-level Coding prompt behavior section to ProfileEditForm with two dropdowns (session title updates + response options), each offering 'Use system default' to inherit the account setting. Wires state, isDirty tracking, and save through buildCodingPromptBehaviorOverrideV1 so omitted knobs stay inherited. Adds i18n keys across en + 9 locales (English baseline copy; translation review pending).
Kunde21
force-pushed
the
profile-system-prompt
branch
from
August 4, 2026 06:51
316fdad to
e669080
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds per-profile overrides for the two coding system-prompt behavior knobs — session title updates and response options — with the account-level setting remaining the default. A profile can override either knob; any knob omitted from the profile inherits the global account default.
Changes
packages/protocol): newCodingPromptBehaviorOverrideV1Schema(partial — no per-field defaults, so omit = inherit global) nested as optionalcodingPromptBehaviorV1onAIBackendProfileSchema. AddsresolveCodingPromptBehaviorV1WithOverride()andapplyCodingPromptBehaviorOverrideToSettings(). A malformed override is dropped via.catch({ v: 1 })so the profile itself stays valid.apps/cli):resolveEffectiveCodingPrompt.tsresolves the selected profile by id (non-throwing) and merges its override over global settings when building the base coding prompt. Built-in / unknown / override-free profiles fall back to the global default — unchanged behavior.apps/ui):getProfileCodingPromptBehaviorOverride(read) +buildCodingPromptBehaviorOverrideV1(save) helpers, and a profile-level "Coding prompt behavior" editor section with two dropdowns, each offering "Use system default" to inherit the account setting. i18n across en + 9 locales.Verification
Notes
Draft — opening for early review.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Note
Add per-profile coding prompt behavior override for session title updates and response options
codingPromptBehaviorV1as an optional field on backend profiles, allowing each profile to override session title update mode and response options mode independently of account-level defaults.CodingPromptBehaviorOverrideV1Schema,resolveCodingPromptBehaviorV1WithOverride, andapplyCodingPromptBehaviorOverrideToSettingsin@happier-dev/protocolto validate, merge, and apply per-profile overrides.resolveEffectiveCodingPromptPlanin the CLI agent to read the active profile's override and apply it before building the base coding prompt plan.ProfileEditForm) for selecting session title update mode and response options mode, initialized from the profile and included in dirty tracking and save payload.Macroscope summarized e669080.