Fixed VariationAxis.hidden being initialized with garbage data#216
Open
SamusAranX wants to merge 1 commit into
Open
Fixed VariationAxis.hidden being initialized with garbage data#216SamusAranX wants to merge 1 commit into
VariationAxis.hidden being initialized with garbage data#216SamusAranX wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In fvar.rs, the hidden flag is currently read like this:
According to the docs linked in that file, the bitshift here is wrong, and a simple
flags & 1 == 1would do.If you have access to a Mac, you can verify this by checking the hidden
GRADaxis in/System/Library/Fonts/SFNS.ttf.(I'd point to another, more freely accessible font, but I'm afraid I'm not aware of any with hidden axes, sorry)