fix(git): handle detached HEAD silently#557
Merged
jakubbortlik merged 1 commit intoharrisoncramer:developfrom May 5, 2026
Merged
fix(git): handle detached HEAD silently#557jakubbortlik merged 1 commit intoharrisoncramer:developfrom
jakubbortlik merged 1 commit intoharrisoncramer:developfrom
Conversation
Allow reviewing a merge request from detached HEAD.
seflue
force-pushed
the
fix/get-current-branch-detached-head
branch
from
3412d88 to
7439c41
Compare
jakubbortlik
reviewed
May 5, 2026
Collaborator
|
Hi @seflue, thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #555.
git branch --show-currentreturns an empty string with exit code 0 when HEAD is detached or the repo has no commits. That's a valid state, not an error. The old code routed it through the error branch anyway, so the operation was cancelled with an error message instead of proceeding.The fix splits the two cases. In detached HEAD, the picker now proceeds with the check-out (the caller in
merge_requests.lua:33already handles nil). Real git failures still notify ERROR.