Merged
Conversation
Signed-off-by: Anthony Petrov <anthony@swirldslabs.com>
JUnit Test Report 81 files + 2 81 suites +2 2m 48s ⏱️ -35s Results for commit 46cf9c5. ± Comparison against base commit 9a572a5. This pull request removes 6 and adds 168 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Integration Test Report 419 files ±0 419 suites ±0 17m 25s ⏱️ - 6m 29s Results for commit 46cf9c5. ± Comparison against base commit 9a572a5. This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
imalygin
reviewed
Apr 13, 2026
imalygin
reviewed
Apr 13, 2026
imalygin
reviewed
Apr 13, 2026
Signed-off-by: Anthony Petrov <anthony@swirldslabs.com>
imalygin
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Introducing the initial implementation of the new
MemoryDataclass - an object similar to theBufferedData, but backed by aMemorySegmentrather than aByteBuffer.This initial implementation supports all the interfaces that the
BufferedDatasupports and exposes pretty much the same API. However, currently, no fast-paths exist for more optimal operations. So this initial version isn't production ready yet. Fast-paths will be delivered in future, separate PRs.See parent story for more details: #767
There's also a one-liner fix in a Gradle script that removes a warning during the build.
Related issue(s):
Fixes #780
Notes for reviewer:
Existing
BufferedDataunit tests have been modified to support the newMemoryDataobject. So the test coverage is identical for both the classes.Checklist