client: cap RateLimitLinearJitterBackoff Retry-After waits at max - #298
Open
official-burak wants to merge 1 commit into
Open
client: cap RateLimitLinearJitterBackoff Retry-After waits at max#298official-burak wants to merge 1 commit into
official-burak wants to merge 1 commit into
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
official-burak
force-pushed
the
cap-retry-after-rate-limit-backoff
branch
from
August 25, 2026 14:02
ebc729f to
4ece3ae
Compare
A 429 or 503 with a large Retry-After could stall longer than RetryWaitMax. Honor max on that path so the configured ceiling is a hard wait limit.
official-burak
force-pushed
the
cap-retry-after-rate-limit-backoff
branch
from
August 25, 2026 14:02
4ece3ae to
853777c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RateLimitLinearJitterBackoffreturned a parsedRetry-Afterduration without applyingmax(RetryWaitMax). A 429 or 503 withRetry-After: 3600(or a far-future HTTP-date) could stall the client for that whole interval even when the caller set a much smaller ceiling.The exponential path in
DefaultBackoffalready treatsmaxas a hard cap. This change does the same for the rate-limit helper: ifRetry-Afteris larger thanmax, waitmaxinstead. Values at or belowmaxare unchanged.DefaultBackoffis left alone; #247 / #283 cover that helper.Related Issue
Fixes #295
How Has This Been Tested?
Fail-then-pass on
TestBackoff_RateLimitLinearJitterBackoff:Retry-Aftergreater thanmaxfailed (expected 1s, got 2sandexpected 3s, got 1h0m0s).Retry-Aftercases still pass.Also ran: