Fix RoundTripper returning both response and error - #299
Open
BetterAndBetterII wants to merge 1 commit into
Open
Fix RoundTripper returning both response and error#299BetterAndBetterII wants to merge 1 commit into
BetterAndBetterII wants to merge 1 commit into
Conversation
On *url.Error from Client.Do (e.g. redirect stop with PassthroughErrorHandler), RoundTrip used to return the response alongside the unwrapped error. That violates http.RoundTripper and makes net/http.Client log that it is ignoring the response. Close any body and return nil with the error instead. Fixes hashicorp#179
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RoundTripper.RoundTripreturned both a non-nil*http.Responseand an error whenClient.Doproduced a*url.Error(for example redirect exhaustion withPassthroughErrorHandler). That violates thehttp.RoundTrippercontract and causesnet/http.Clientto logRoundTripper returned a response & error; ignoring response.On error, close any response body and return
nil, err, still unwrapping*url.Errorso the outer client does not double-wrap.Test plan
go test -count=1 -race ./...StandardClient()so the net/http log line does not appearFixes #179