fix(i18n): stop reading a table's alignment row as prose - #36
Merged
Conversation
A right-aligned column writes its delimiter as | ---: |, which the space -before-punctuation rule read as a space before a colon. No page here has a right-aligned column, so the checker has been reporting clean by luck rather than by being correct; the fault surfaced in the HALMET repository, whose GPIO table is right-aligned. Reproduced before fixing by adding such a table to docs/fi: one false positive, gone afterwards, and all nine languages unchanged either way. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_typography.pyread a markdown table's alignment row as prose.A right-aligned column writes its delimiter as
| ---: |, and the rule that forbids a space before; : ! ?matched the space in front of that colon. The row is table syntax, not a sentence.Why it never showed here
No page in this repository has a right-aligned column, so the checker has been reporting clean by luck rather than by being correct. The fault surfaced in hatlabs/halmet#18, where the GPIO reference table right-aligns its first column, and the same script — copied from here — reported two false positives on a correct page.
Reproduced before fixing
Adding such a table to
docs/fi/produces exactly one false positive:After the fix the same file reports clean, and all nine translated languages are unchanged in both directions — they passed before and they pass now, which is the point: this must not alter any existing verdict.
Note
This is the fifth false positive this checker has produced during its short life, and every one of them was caught the same way — by running it against pages already reviewed and fixed. If it reports a defect there, the defect is in the checker. That is worth keeping as the habit rather than trusting a clean first run.
🤖 Generated with Claude Code