Skip to content

Harden dashboard WebView (disable file/content access, mixed content, JS popups) #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hawkff merged 1 commit into from
Jun 21, 2026
Merged

Harden dashboard WebView (disable file/content access, mixed content, JS popups) #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions app/src/main/java/io/nekohasekai/sagernet/ui/WebviewFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,25 @@ class WebviewFragment : ToolbarFragment(R.layout.layout_webview), Toolbar.OnMenu
// webview
WebView.setWebContentsDebuggingEnabled(BuildConfig.DEBUG)
mWebView = binding.webview
mWebView.settings.domStorageEnabled = true
mWebView.settings.javaScriptEnabled = true
mWebView.settings.apply {
// The Clash/yacd dashboard is a JS SPA talking to the local Clash API, so JS
// and DOM storage are required. Everything else is locked down: the dashboard
// (a user-editable URL) must never be able to read the device filesystem or
// content providers, escalate from file:// origins, or downgrade to cleartext
// resources on an https page.
javaScriptEnabled = true
domStorageEnabled = true
allowFileAccess = false
allowContentAccess = false
@Suppress("DEPRECATION")
allowFileAccessFromFileURLs = false
@Suppress("DEPRECATION")
allowUniversalAccessFromFileURLs = false
mixedContentMode = WebSettings.MIXED_CONTENT_NEVER_ALLOW
// No automatic JS-initiated window.open popups.
javaScriptCanOpenWindowsAutomatically = false
setSupportMultipleWindows(false)
}
mWebView.webViewClient = object : WebViewClient() {
override fun onReceivedError(
view: WebView?, request: WebResourceRequest?, error: WebResourceError?
Expand Down
Loading