feat(plugin-js): scaffold JS/TS plugin, hermetic js_install driver - #361
Draft
raphaelvigee wants to merge 1 commit into
Draft
feat(plugin-js): scaffold JS/TS plugin, hermetic js_install driver#361raphaelvigee wants to merge 1 commit into
raphaelvigee wants to merge 1 commit into
Conversation
First-party JS/TS ecosystem plugin (M0+M1), mirroring the plugin-go / plugin-go-cdylib two-crate split (logic crate + thin stabby cdylib wrapper). - Provider: package.json discovery, pnpm-workspace.yaml + npm "workspaces" member resolution. - js_install: hermetic per-(name,version,integrity) dependency fetch, SRI verification, platform baked into the cache key, postinstall scripts off by default with an explicit allowlist enforced before any network I/O. Reviewed by feature-quality/code-quality/hermeticity; a tar-slip symlink escape and an uncacheable (host-toolchain-dependent) lifecycle-script hash were found and fixed, each with a regression test. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M3wZfyPsG8stfRQuybLRjN
raphaelvigee
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M0+M1 of the JS/TS heph plugin plan (part 1/6 of the stack).
First-party JS/TS ecosystem plugin, mirroring the plugin-go/plugin-go-cdylib two-crate split (logic crate + thin stabby cdylib wrapper — a loadable dylib, not a compiled-in builtin).
Reviewed by feature-quality/code-quality/hermeticity; a tar-slip symlink escape and an uncacheable (host-toolchain-dependent) lifecycle-script hash were found and fixed, each with a regression test.
Test plan
Stack created with GitHub Stacks CLI • Give Feedback 💬