clarify the filter() return type in the generic-functions exercise - #351
Merged
Conversation
) The task said push() and filter() match the signature of Array methods, while filter() has to return MyArray<T> rather than T[] — otherwise the newColl.items line from the very same example does not type-check. Now the text spells out what matches (the callback parameters) and what differs (the return type), so a student arrives at the same signature as the teacher's solution. The type and the test are unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
fey
force-pushed
the
fix/269-generic-filter-return-type
branch
from
August 5, 2026 15:25
223ccda to
3462c97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #269
Задание урока «Дженерики (Функции)» говорило, что
push()иfilter()«совпадают по сигнатуре с методами Array». Ноfilter()обязан возвращатьMyArray<T>, а неT[]: иначеnewColl.itemsиз примера в этом же задании не типизируется. Из-за этого студент решил, что решение учителя ошибочно.Теперь текст разделяет, что совпадает (параметры колбэка), а что отличается (тип возврата).
index.tsиtest.tsне менялись.🤖 Generated with Claude Code