fix(lint): skip layoutsubtree canvas transform conflicts#1832
Open
AjTheSpidey wants to merge 1 commit into
Open
fix(lint): skip layoutsubtree canvas transform conflicts#1832AjTheSpidey wants to merge 1 commit into
AjTheSpidey wants to merge 1 commit into
Conversation
miguel-heygen
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took the html-in-canvas false-positive part from #1789.\n\nThis makes gsap_css_transform_conflict ignore CSS transforms that only belong to a canvas marked layoutsubtree. I think that case is safe to skip because the canvas is acting as the captured subtree boundary, not a normal DOM element where GSAP would accidentally wipe out authored centering/scale.\n\nI also reused the existing simple selector helper for inline styles while I was in there.\n\nThis worked locally for me:\n- bun run --filter @hyperframes/parsers build\n- bun run --filter @hyperframes/lint test -- src/rules/gsap.test.ts\n- bun run --filter @hyperframes/lint typecheck\n- bun x oxfmt --check packages/lint/src/rules/gsap.ts packages/lint/src/rules/gsap.test.ts\n- bun x oxlint --no-error-on-unmatched-pattern packages/lint/src/rules/gsap.ts packages/lint/src/rules/gsap.test.ts