Skip to content

fix(cli): forward GIF and frame-format options in batch renders#1833

Open
SyntaxSawdust wants to merge 2 commits into
heygen-com:mainfrom
SyntaxSawdust:fix/batch-render-forwarding-options
Open

fix(cli): forward GIF and frame-format options in batch renders#1833
SyntaxSawdust wants to merge 2 commits into
heygen-com:mainfrom
SyntaxSawdust:fix/batch-render-forwarding-options

Conversation

@SyntaxSawdust

Copy link
Copy Markdown

What

Batch renders now carry the parsed --gif-loop and --video-frame-format options into each row render.

Why

hyperframes render --batch validated these flags, but the batch render base options did not include the parsed values. That meant row renders silently used defaults even when callers requested a finite GIF loop count or a specific source video frame extraction format. Single renders already forwarded both options correctly.

How

  • Added gifLoop and videoFrameFormat to the shared batch renderOptionsBase.
  • Added a command-handler regression test that runs a one-row GIF batch render and asserts the mocked render job receives format: "gif", gifLoop: 3, and videoFrameFormat: "png".
  • Mocked browser resolution in the test so the regression stays focused on option forwarding.

Test plan

  • Unit tests added/updated
  • Manual testing performed
  • Documentation updated (not applicable)

Commands:

  • bun run --filter @hyperframes/cli test -- src/commands/render.test.ts -t "forwards gif loop and video frame format to batch row renders"
  • bun run --filter @hyperframes/cli test -- src/commands/render.test.ts
  • bun run --filter @hyperframes/cli typecheck
  • bunx oxlint packages/cli/src/commands/render.ts packages/cli/src/commands/render.test.ts
  • bunx oxfmt --check packages/cli/src/commands/render.ts packages/cli/src/commands/render.test.ts
  • git diff --check
  • bun run --filter @hyperframes/cli test

Batch renders now carry parsed GIF loop and source video frame-format options into each row render, matching single-render behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants