fix(cli): forward GIF and frame-format options in batch renders#1833
Open
SyntaxSawdust wants to merge 2 commits into
Open
fix(cli): forward GIF and frame-format options in batch renders#1833SyntaxSawdust wants to merge 2 commits into
SyntaxSawdust wants to merge 2 commits into
Conversation
Batch renders now carry parsed GIF loop and source video frame-format options into each row render, matching single-render behavior.
miguel-heygen
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Batch renders now carry the parsed
--gif-loopand--video-frame-formatoptions into each row render.Why
hyperframes render --batchvalidated these flags, but the batch render base options did not include the parsed values. That meant row renders silently used defaults even when callers requested a finite GIF loop count or a specific source video frame extraction format. Single renders already forwarded both options correctly.How
gifLoopandvideoFrameFormatto the shared batchrenderOptionsBase.format: "gif",gifLoop: 3, andvideoFrameFormat: "png".Test plan
Commands:
bun run --filter @hyperframes/cli test -- src/commands/render.test.ts -t "forwards gif loop and video frame format to batch row renders"bun run --filter @hyperframes/cli test -- src/commands/render.test.tsbun run --filter @hyperframes/cli typecheckbunx oxlint packages/cli/src/commands/render.ts packages/cli/src/commands/render.test.tsbunx oxfmt --check packages/cli/src/commands/render.ts packages/cli/src/commands/render.test.tsgit diff --checkbun run --filter @hyperframes/cli test