fix: dead code cleanup, missing MIME types, partial download leak#1836
Open
fix2015 wants to merge 1 commit into
Open
fix: dead code cleanup, missing MIME types, partial download leak#1836fix2015 wants to merge 1 commit into
fix2015 wants to merge 1 commit into
Conversation
- formatSpeed had identical branches in its ternary — simplified - file server was missing MIME types for avif, flac, m4a, mov, ico so those files got served as application/octet-stream - removed unreachable guard in parseObjectPositionAxis - partial downloads weren't cleaned up on failure so the next call would find and use the corrupted file — now removes partials in catch block - added description to @hyperframes/core package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few things I noticed while going through the codebase: