fix: reject invalid conversation parameters - #4
Open
evanmarshall wants to merge 11 commits into
Open
evanmarshall wants to merge 11 commits into
evanmarshall wants to merge 11 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of chatwoot#15623 for Ito QA evaluation.
Upstream PR: chatwoot#15623
Upstream author: @sojan-official
Upstream head commit:
2f14c65856c1bf0fbe8e894dbd1d2e471404ad54Conversation priority mutations and filters now reject malformed request values through Chatwoot's existing
422 Unprocessable Entitypaths instead of allowing enum, bind, or database errors to reach Sentry.Closes
How to reproduce
priority: "none"value to a conversation priority endpoint. It previously reached the enum assignment and raisedArgumentError.valuescontains an object. It previously reached Active Record as a structured bind value and raisedTypeError.What changed
nonevalue from the public priority API schemas.AGENTS.md.