Improve error handling: stop swallowing errors and propagate proper HTTP status codes - #1
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…TTP status Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes several places in
main.pywhere errors were silently swallowed or surfaced as unhelpful500s.Relay tasks no longer swallow errors.
tcp_to_wspreviously had a blanketexcept Exception: pass, and unexpected exceptions inws_to_tcpescaped into a task that was never awaited (dropped + "Task exception was never retrieved" warnings). Both now distinguish expected teardown from real failures:websocket_tunnelsurfaces task failures. Afterasyncio.wait(..., FIRST_COMPLETED)it nowgathers the cancelledpendingtasks (clean teardown) and re-raises any exception from the finished task instead of dropping it. The outer handler routes through the newrecord_error(...)helper (incrementsstats["total_errors"]+ appends toerror_logs).Malformed request bodies return 400, not 500. Added
parse_json_body()(rejects non-JSON / non-object bodies) and_to_float()(rejects non-numericlimit_value), wired intoapi_login,api_change_password,create_link, andtoggle_link. Previouslyawait request.json()/float(...)on bad input raised unhandled →500.http_proxydifferentiates failures. Guardshttp_client is None(503), mapshttpx.TimeoutException→504,httpx.HTTPError→502, and logs/records all viarecord_error.Verification
Ran the app locally and exercised the paths: invalid-JSON and array bodies →
400, wrong password →401, valid login →200, non-numericlimit_value→400, valid link creation →200.python -m py_compilepasses; the only pyflakes warnings are pre-existing unused imports untouched by this change.Link to Devin session: https://app.devin.ai/sessions/aecaede8a13e4e1e990020243c687dc7
Requested by: @hmilan1366