fix: report LBC stack readiness

[patrickleet]

Summary

• derive status.ready from the observed Helm Release and PodIdentity readiness
• keep the convenience status field aligned with the Crossplane Ready condition

Validation

• installed the branch from source with hops config install --path
• configuration package Installed=True and Healthy=True
• LBCStack status.ready=true, Ready=True, and Synced=True
• Helm release chart 3.5.0 Ready=True
• aws-load-balancer-controller deployment 2/2 Ready and Available

Summary by CodeRabbit

• Bug Fixes
  • Readiness status now accurately reflects whether both the load balancer release and pod identity are ready.
  • Removed the previous readiness state that always reported as false.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 836e550d-2aec-4170-ae53-41940e9f4bc0

📥 Commits

Reviewing files that changed from the base of the PR and between 5c04896 and f1baccf.

📒 Files selected for processing (1)

• functions/render/001-state-status.yaml.gotmpl

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The readiness status template now reports ready only when both helm-release-alb and pod-identity are ready.

Changes

Readiness status

Layer / File(s)	Summary
Combined readiness condition functions/render/001-state-status.yaml.gotmpl	The template replaces the fixed false value with a conjunction that requires Helm release readiness and AWS Pod Identity readiness.

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: ⚪ Minimal · up to f1bac

This localized status-reporting change aligns readiness fields with observed resource health and has no actionable merge-blocking risk remaining after normal checks and review.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: reporting LBC stack readiness.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/lbc-status-ready

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Published Crossplane Package

The following Crossplane package was published as part of this PR:

Package: ghcr.io/hops-ops/aws-lbc-stack:pr-45-5aa08430f2965d6ed60a18c9ca49fb0bbd482b52

View Package